Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved GitLab checks to GitHub's action #402

Merged
merged 6 commits into from
Apr 30, 2024
Merged

Moved GitLab checks to GitHub's action #402

merged 6 commits into from
Apr 30, 2024

Conversation

Bullrich
Copy link
Contributor

Resolves #401

@Bullrich Bullrich self-assigned this Apr 30, 2024
@Bullrich Bullrich marked this pull request as ready for review April 30, 2024 14:27
@Bullrich Bullrich requested a review from a team as a code owner April 30, 2024 14:27
@Bullrich Bullrich requested a review from a team April 30, 2024 14:27
mutantcornholio
mutantcornholio requested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@mutantcornholio mutantcornholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have separate checks for lint and test please?
If check fails, I'd like to know if it's only codestyle or the tests too.

@Bullrich
Copy link
Contributor Author

Can we have separate checks for lint and test please? If check fails, I'd like to know if it's only codestyle or the tests too.

We have them:
image

check-lint checks the lint, and check-test checks the test.

If one fails the other one will still run

@mutantcornholio
Copy link
Contributor

I just noticed something: upon submitting a review, the checks were restarted. We should probably select, which pull_request events we're listening for

@Bullrich
Copy link
Contributor Author

I just noticed something: upon submitting a review, the checks were restarted. We should probably select, which pull_request events we're listening for

It was a coincidence, I just pushed.

By default, it only uses opened, synchronized and reopened unless you specify.

@mutantcornholio
Copy link
Contributor

Can we have separate checks for lint and test please? If check fails, I'd like to know if it's only codestyle or the tests too.

We have them: image

check-lint checks the lint, and check-test checks the test.

If one fails the other one will still run

ah, sorry, my bad. I saw them in the single file, and thought that it'll result in the same check status

@Bullrich Bullrich merged commit 1561795 into main Apr 30, 2024
9 checks passed
@Bullrich Bullrich deleted the test-to-action branch April 30, 2024 14:45
forgetso added a commit to prosopo/polkadot-testnet-faucet that referenced this pull request May 1, 2024
@forgetso @mordamax
@Bullrich @dependabot
Updates 3 (#7)
81a777a 
* Update paseo RPC wss://sys.dotters.network/paseo (paritytech#398)

* Prettier write

* Make properties public. Remove try catches. Lint

* remove console.log

* Increase test timeout

* try installing playwright with yarn

* Moved GitLab checks to GitHub's action (paritytech#402)

Resolves paritytech#401

* Bump yaml from 2.4.1 to 2.4.2 in /client in the npm_and_yarn group across 1 directory (paritytech#403)

* remove empty spaces

* Address more PR comments

* Address comments

* Add type check function to test file

* Fix import so that it works from tests dir2

* Update eng-automation

* fix import

* try after linting

* Suppress ESLint to get CICD to run

* yarn:fix

* pass block number to mock provider

* fix tests

* yarn format:fix

---------

Co-authored-by: Maksym H <[email protected]>
Co-authored-by: Javier Bullrich <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndWeHaveAPlan AndWeHaveAPlan AndWeHaveAPlan approved these changes

@mordamax mordamax mordamax approved these changes

@mutantcornholio mutantcornholio mutantcornholio approved these changes

@rzadp rzadp Awaiting requested review from rzadp

Assignees

@Bullrich Bullrich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate gitlab checks to github
5 participants
@Bullrich @mutantcornholio @mordamax @AndWeHaveAPlan @rzadp