Introduce reactions #428
Merged
Introduce reactions #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+124
to
128
| sendReaction(roomId, eventId, "👀"); | ||
| if (!arg0) { | ||
| logger.warn("Address not provided, skipping"); | ||
| sendReaction(roomId, eventId, "😕"); | ||
| sendMessage(roomId, `${sender} Please provide an address to be funded.`); | ||
| return; |
There was a problem hiding this comment.
Sounds like there's no need to send 👀 reaction, if we're sending a 😕 right after.
Why not move sendReaction(roomId, eventId, "👀"); after synchronous checks?
There was a problem hiding this comment.
I see what you mean, also thought about it.
In my pedantic mind it's more consistent to always have the same pattern:
seen 👀->👍 OKseen 👀->😕 FAIL
Changing this would introduce a 😕 FAIL for a message that "has not been seen" in contrast with others.
Those were just my thoughts, don't know if it makes sense :D
|
Note: investigating the failing E2E tests. Not on issue with the PR, they fail on clean master as well. Edit: Master fixed, now we have some actual failure on the PR. |
mutantcornholio
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to how the tip bot works, introduced reactions.
The user will get immediate feedback that the command has been received.