Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce no-std compatibility in CI #1791

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,17 @@ jobs:
- run: RUSTFLAGS=-Dwarnings cargo check --target x86_64-unknown-linux-gnu --package smoldot-light --locked --no-default-features --features std
- run: RUSTFLAGS=-Dwarnings cargo check --target i686-unknown-linux-gnu --package smoldot-light --locked --no-default-features --features std

check-no-std:
runs-on: ubuntu-latest
container:
image: rust
steps:
- uses: actions/[email protected]
- uses: Swatinem/rust-cache@v1
- run: rustup default nightly
- run: rustup component add rust-src --toolchain nightly-x86_64-unknown-linux-gnu # Necessary for `-Z build-std` below
- run: RUSTFLAGS=-Dwarnings cargo +nightly build --package smoldot --no-default-features -Z build-std=core,alloc --target=x86_64-unknown-uefi

fuzzing-binaries-compile:
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -229,7 +240,7 @@ jobs:
all-ci:
# This dummy job depends on all the mandatory checks. It succeeds if and only if CI is
# considered successful.
needs: [test-64bits, test-32bits, wasm-node-check, wasm-node-size-diff, check-features, fuzzing-binaries-compile, check-rustdoc-links, fmt, clippy, cargo-deny, cargo-spellcheck, wasm-node-versions-match]
needs: [test-64bits, test-32bits, wasm-node-check, wasm-node-size-diff, check-features, check-no-std, fuzzing-binaries-compile, check-rustdoc-links, fmt, clippy, cargo-deny, cargo-spellcheck, wasm-node-versions-match]
runs-on: ubuntu-latest
steps:
- run: echo Success