feat: update google cloud storage version #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Moumouls
commented
Nov 20, 2024
•
Moumouls
commented
- Need Node 18+
- Allow to remove the warning about punycode
- Needed to update semantic release
# Conflicts: # package-lock.json
|
@mtrezza it seems that we have issue with codecov should we remove it ? |
mtrezza
reviewed
Nov 20, 2024
There was a problem hiding this comment.
I believe we'd need to do this in separate PRs if possible:
- ci: semantic-release upgrade; it's a bit tricky and wouldn't work the way it's done here. I can do that in the coming days. Unless it's urgent for you, then let me know.
- refactor: upgrade gcs lib
- feat: add support for Node #, remove support for node #
Maybe some PRs need to be combined, or reordered, we'll see.
Codecodv needs to use the GH Action, and probably some repo permission, also a separate PR, I'll take care of that.
|
@Moumouls I've merged the PRs already, I think you only need to upgrade the GCS lib now and it should be done. I recommend to revert all changes in this PR and just do clean upgrade of the GCS lib. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.