feat: Revise createFile logic to return modified filenames and location #242
+75
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add error handling for key generation - Standardize return object with location, url, and filename - Add support for optional config parameter - Return s3 response explicitly as a separate variable
Thanks for opening this pull request! |
AdrianCurtin
changed the title
AdrianCurtin
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #242 +/- ##
==========================================
+ Coverage 97.18% 97.24% +0.06%
==========================================
Files 2 2
Lines 213 218 +5
==========================================
+ Hits 207 212 +5
Misses 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtrezza
reviewed
Feb 1, 2025
|
@mtrezza Which tests are failing? |
|
See the CI job panel |
|
@mtrezza Added tests for the two conditions that were missing |
|
@mtrezza |
|
@vahidalizad What do you think? |
vahidalizad
reviewed
Mar 9, 2025
|
|
||
| let key_without_prefix = filename; | ||
| if (this._generateKey instanceof Function) { | ||
| try { |
There was a problem hiding this comment.
I believe removing the try block would achieve the same result while preserving the original error trace and improving readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If parse-community/parse-server#9557 is merged,
this will address #237
This change will affect specific tests that check the response.Location argument and may affect any direct adapter usage of createFile that explicitly uses the s3 server response.
Closes: #237