Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade to eslint 9.19.0 #9580

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jan 30, 2025

Pull Request

Issue

Closes: FILL_THIS_OUT

Approach

Fair few changes had to be made to support the updated recommended eslint rules

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

dependabot bot and others added 2 commits January 30, 2025 00:48
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.0 to 9.19.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.57.0...v9.19.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: update eslint feat: Update eslint Jan 30, 2025
Copy link

parse-github-assistant bot commented Jan 30, 2025

Thanks for opening this pull request!

  • ❌ Please fill out all fields with a placeholder FILL_THIS_OUT, otherwise your pull request will be closed. If a field does not apply to the pull request, fill in n/a.

@dblythy dblythy changed the title feat: Update eslint refactor: Update eslint to v9 Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.48%. Comparing base (59e46d0) to head (61f0514).
Report is 4 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #9580      +/-   ##
==========================================
- Coverage   93.50%   93.48%   -0.03%     
==========================================
  Files         186      186              
  Lines       14804    14804              
==========================================
- Hits        13842    13839       -3     
- Misses        962      965       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza changed the title refactor: Update eslint to v9 refactor: Upgrade to eslint 9.19.0 Jan 31, 2025
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for merge?

@dblythy
Copy link
Member Author

dblythy commented Feb 1, 2025

Yep 😊

@dblythy dblythy requested a review from a team February 1, 2025 10:46
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 889dbb5 into parse-community:alpha Feb 1, 2025
22 of 24 checks passed
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.0.0-alpha.10

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants