-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PC-33767) build(yarn): bump yarn #7471
Changes from all commits
fa555ed
012dda0
751b525
aef62ee
c98f8ec
818d86b
41e872f
03d0f52
be7381e
6f83f0f
f897d72
300fb0e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,9 @@ eval "$(devbox generate direnv --print-envrc)" | |
|
||
layout node | ||
|
||
source_env ./scripts/install_node_modules_when_not_installed.sh | ||
source ./scripts/load_certificate.sh | ||
export NODE_TLS_REJECT_UNAUTHORIZED=0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. j'imagine que si on montre ça coté sécu, il y aura un blocage There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
source ./scripts/install_node_modules_when_not_installed.sh | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
ANDROID_HOME="$HOME/Library/Android/sdk" | ||
if [ -d "$ANDROID_HOME" ]; then | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,6 +37,8 @@ jobs: | |
runs-on: ubuntu-22.04 | ||
if: ${{ github.actor != 'dependabot[bot]' }} | ||
steps: | ||
- name: Enable Corepack | ||
run: corepack enable | ||
- uses: actions/[email protected] | ||
with: | ||
ref: ${{ inputs.REF }} | ||
|
@@ -67,7 +69,7 @@ jobs: | |
key: v1-yarn-pro-dependency-cache-${{ runner.os }}-${{ hashFiles('**/yarn.lock') }} | ||
restore-keys: | | ||
v1-yarn-pro-dependency-cache-${{ runner.os }}-${{ hashFiles('**/yarn.lock') }} | ||
- run: yarn install --immutable | ||
- run: yarn install | ||
- run: yarn build:${{ inputs.ENV }} | ||
env: | ||
# By default NodeJS processes are limited to 512MB of memory | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,6 +41,7 @@ local.properties | |
node_modules/ | ||
npm-debug.log | ||
yarn-error.log | ||
**/.yarn/install-state.gz | ||
|
||
# fastlane | ||
# | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
nodeLinker: node-modules | ||
checksumBehavior: update |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ | |
"homepage": ".", | ||
"scripts": { | ||
"preandroid": "./scripts/start_android_emulator_with_certificate.sh", | ||
"android": "react-native run-android", | ||
"android": "yarn preandroid && react-native run-android", | ||
"android:prod": "yarn android --variant=productionDebug --appId=app.passculture.webapp", | ||
"android:staging": "yarn android --variant=stagingDebug --appId=app.passculture.staging", | ||
"android:testing": "yarn android --variant=apptestingDebug --appId=app.passculture.testing", | ||
|
@@ -35,12 +35,11 @@ | |
"generate:api:client": "SWAGGER_CODEGEN_CLI_VERSION=3.0.32 ./scripts/generate_api_client.sh", | ||
"generate:api:client:silicon": "SWAGGER_CODEGEN_CLI_VERSION=3.0.32 ./scripts/generate_api_client_silicon.sh", | ||
"preios": "./scripts/check_xcode_version.sh", | ||
"ios": "react-native run-ios", | ||
"ios": "yarn preios && react-native run-ios", | ||
"ios:prod": "yarn ios --scheme PassCulture-Production", | ||
"ios:staging": "yarn ios --scheme PassCulture-Staging", | ||
"ios:testing": "yarn ios --scheme PassCulture-Testing", | ||
"postinstall": "patch-package && jetify", | ||
"prepush": "git pull --rebase origin master", | ||
"start": "react-native start", | ||
"start:web": "vite", | ||
"start:web:development": "yarn start:web --mode=development", | ||
|
@@ -50,9 +49,9 @@ | |
"start:web:testing": "yarn start:web --mode=testing", | ||
"storybook": "NODE_OPTIONS='--openssl-legacy-provider' TZ=UTC start-storybook --static-dir ./public -p 6006", | ||
"test": "yarn test:lint && yarn test:types && yarn test:unit && yarn test:unit:web", | ||
"test:deadcode": "yarn --silent ts-prune", | ||
"test:deadcode": "yarn ts-prune", | ||
"test:deadcode:count": "yarn test:deadcode | wc -l", | ||
"test:deadcode:update": "yarn --silent test:deadcode > scripts/dead_code_snapshot.txt", | ||
"test:deadcode:update": "yarn test:deadcode > scripts/dead_code_snapshot.txt", | ||
"test:e2e:android:staging": "./scripts/run_e2e_tests.sh test android staging", | ||
"test:e2e:ios:staging": "./scripts/run_e2e_tests.sh test ios staging", | ||
"test:e2e:web:staging": "./scripts/run_e2e_tests.sh test web staging", | ||
|
@@ -69,7 +68,7 @@ | |
"test:storybook:accessibility": "TZ=UTC axe-storybook --storybook-address http://localhost:6006", | ||
"test:types": "tsc", | ||
"test:types:noUncheckedIndexedAccess": "grep --recursive --line-number ./src --regexp '// @ts-expect-error: because of noUncheckedIndexedAccess' | awk -F: '{print $1\":\"$2}' | sort", | ||
"test:types:noUncheckedIndexedAccess:update": "yarn --silent test:types:noUncheckedIndexedAccess > scripts/noUncheckedIndexedAccess_snapshot.txt", | ||
"test:types:noUncheckedIndexedAccess:update": "yarn test:types:noUncheckedIndexedAccess > scripts/noUncheckedIndexedAccess_snapshot.txt", | ||
"test:unit": "TZ=UTC JEST=true node --no-experimental-fetch --no-compilation-cache --expose-gc ./node_modules/.bin/jest --forceExit --logHeapUsage", | ||
"test:unit:ci": "yarn test:unit --maxWorkers=6 --coverage --ci --reporters=default --reporters=jest-junit", | ||
"test:unit:full": "TZ=UTC JEST=true jest --collect-coverage", | ||
|
@@ -83,11 +82,6 @@ | |
"trigger:testing:deploy": "./scripts/deploy_new_version.sh testing/v patch", | ||
"update:tools": "nix flake update && direnv exec . devbox update && git commit --only flake.lock devbox.lock --message '(BSR) chore(deps): update tools'" | ||
}, | ||
"husky": { | ||
"hooks": { | ||
"pre-push": "yarn prepush" | ||
} | ||
}, | ||
Comment on lines
-86
to
-90
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pour quelles raisons il a été supprimé avec le bump de Yarn ? |
||
"dependencies": { | ||
"@algolia/client-search": "^4.24.0", | ||
"@amplitude/analytics-react-native": "^1.0.1", | ||
|
@@ -320,7 +314,7 @@ | |
"react-native-web-linear-gradient": "^1.1.2", | ||
"react-query-native-devtools": "^3.0.1", | ||
"react-test-renderer": "18.2.0", | ||
"reassure": "^0.7.2", | ||
"reassure": "1.1.0", | ||
"resolve": "^1.20.0", | ||
"resolve-url-loader": "^3.1.2", | ||
"sass-loader": "^11.0.1", | ||
|
@@ -364,5 +358,6 @@ | |
"./jsx-dev-runtime": "./jsx-dev-runtime.js", | ||
"./jsx-runtime": "./jsx-runtime.js", | ||
"./": "./" | ||
} | ||
}, | ||
"packageManager": "[email protected]" | ||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -4,4 +4,4 @@ set -o errexit | |||||
set -o nounset | ||||||
set -o pipefail | ||||||
|
||||||
VERSION=$(yarn --silent json -f package.json version) | ||||||
VERSION=$(node -p "require('./package.json').version") | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pour etre plus explicit et lisible, je recommande toujours les options en versions longues dans le code versionné
Suggested change
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,5 +73,6 @@ | |
}, | ||
"resolutions": { | ||
"semver": "^7.5.2" | ||
} | ||
}, | ||
"packageManager": "[email protected]" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je pense que c'est inutile de le faire une seconde fois, c'est déjà faire ligne 12