Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-33894) feat(identityCheck): change tests name in DMSModal #7495

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

lbeneston-pass
Copy link
Contributor

@lbeneston-pass lbeneston-pass commented Jan 9, 2025

PC-33894

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion
  • I am aware of all the best practices and respected them.

Screenshots

delete if no UI change

Platform Mockup/Before After
iOS
Android
Phone - Chrome
Desktop - Chrome

Copy link

sonarqubecloud bot commented Jan 9, 2025

Copy link

sonarqubecloud bot commented Jan 9, 2025

@lbeneston-pass lbeneston-pass changed the title (BSR) feat(identityCheck): change tests name in DMSModal (PC-33894) feat(identityCheck): change tests name in DMSModal Jan 9, 2025
@lbeneston-pass lbeneston-pass merged commit 15b4f78 into master Jan 9, 2025
59 checks passed
@lbeneston-pass lbeneston-pass deleted the bsr-change-name-in-test branch January 9, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants