-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PC-33637) feat(offer): add chronicles section #7556
(PC-33637) feat(offer): add chronicles section #7556
Conversation
1e2b046
to
e4b5164
Compare
8834167
to
2c2fe27
Compare
2c2fe27
to
e49078e
Compare
src/features/chronicle/components/ChronicleCardList/ChronicleCardList.web.tsx
Outdated
Show resolved
Hide resolved
e702db2
to
7418716
Compare
.../chronicle/adapters/offerChroniclesToChronicleCardData/offerChroniclesToChronicleCardData.ts
Show resolved
Hide resolved
src/features/offer/components/OfferContent/OfferContent.native.test.tsx
Outdated
Show resolved
Hide resolved
e391fc7
to
fff3819
Compare
src/features/chronicle/components/ChronicleCardList/ChronicleCardList.web.test.tsx
Outdated
Show resolved
Hide resolved
src/features/chronicle/components/ChronicleCardList/ChronicleCardList.web.test.tsx
Outdated
Show resolved
Hide resolved
b8825a1
to
7fbf2f5
Compare
src/features/chronicle/components/ChronicleCardList/ChronicleCardList.web.test.tsx
Outdated
Show resolved
Hide resolved
103494d
to
6759081
Compare
6759081
to
987325e
Compare
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D'après les règles il vaut mieux privilégié l'act vide plus que le waitFor mais ok
Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-33637
Intégration de la section "L'avis du book club" dans la page offre. Les données proviennent du backend
Mise à jour des type de l'api
Mise à jour du hook
useChronicles
pour pouvoir passer une fonction de transformation directement dans leselect
du useQueryRefactor des composants
ChronicleCard
etChronicleCardList
pour permettre plus de flexibilité côté natif et côté web.Intégration du composant
ChronicleCardList
dans la page Offre et câblage avec la donnéeRemontée de certains composants depuis
OfferBody
versOfferContentBase
Possibilité de gérer l'écart entre les tuiles via une prop
Flakiness
If I had to re-run tests in the CI due to flakiness, I add the incident on Notion
Checklist
I have:
Screenshots
Android
Kapture.2025-01-23.at.00.57.47.mp4
iOS
Kapture.2025-01-23.at.00.59.58.mp4
Web
Kapture.2025-01-23.at.11.59.09.mp4
Kapture.2025-01-23.at.12.00.07.mp4
Best Practices
Click to expand
These rules apply to files that you make changes to. If you can't respect one of these rules, be sure to explain why with a comment. If you consider correcting the issue is too time consuming/complex: create a ticket. Link the ticket in the code.as
(type assertions are removed at compile-time, there is no runtime checking associated with a type assertion. There won’t be an exception ornull
generated if the type assertion is wrong). In certain casesas const
is acceptable (for example when defining readonly arrays/objects). Usingas
in tests is tolerable.any
(when you want to accept anything because you will be blindly passing it through without interacting with it, you can useunknown
). Usingany
in tests is tolerable.!
when you know that the value can’t benull
orundefined
).@ts-expect-error
and@eslint-disable
.yarn test:lint
,yarn test:types
,yarn start:web
...).gap
(ViewGap
) instead of<Spacer.Column />
,<Spacer.Row />
or<Spacer.Flex />
.Test specific:
user
tofireEvent
.setFeatureFlags
. If not possible, mention which one(s) you want to mock in a comment (example:jest.spyOn(useFeatureFlagAPI, 'useFeatureFlag').mockReturnValue(true) // WIP_NEW_OFFER_TILE in renderPassPlaylist.tsx
)await act(async () => {})
andawait waitFor(/* ... */)
byawait screen.findBySomething()
.act
by default andwaitFor
as a last resort.Advice: