Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC-33895 fix chronicles route #15938

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

cnormant-pass
Copy link
Contributor

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-33895

Vérifications

  • J'ai écrit les tests nécessaires
  • Je présente des excuses pour avoir mergé trop rapidement la PR PC-33895 chronicles route #15900 y oubliant un commit à squasher, qui sera mal nommé sur master à tout jamais 😢

@cnormant-pass
Copy link
Contributor Author

cnormant-pass commented Jan 20, 2025

Not a real breaking change parce que la route vient seulement d'arriver en testing (il y a quelques minutes!)
Plutôt un hot fix

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Visit the preview URL for this PR (updated for commit 5c1f72a):

https://pc-pro-testing--pr15938-pc-33895-fix-chronic-zqkcv6v7.web.app

(expires Wed, 22 Jan 2025 15:07:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

@cnormant-pass cnormant-pass force-pushed the pc-33895-fix-chronicles-route branch from 0e8db40 to 5c1f72a Compare January 20, 2025 15:05
@cnormant-pass cnormant-pass merged commit 545c340 into master Jan 20, 2025
27 of 28 checks passed
@cnormant-pass cnormant-pass deleted the pc-33895-fix-chronicles-route branch January 20, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants