(PC-33946)[API] feat: add publicationDate in offer route & indexation #15959
+145
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpeyrou-pass
commented
Jan 21, 2025
|
|
||
| @is_eligible_for_search.expression # type: ignore[no-redef] | ||
| def is_eligible_for_search(cls) -> BooleanClauseList: # pylint: disable=no-self-argument | ||
| return sa.and_(cls._released, Stock._bookable) | ||
| return sa.or_( | ||
| sa.and_( |
There was a problem hiding this comment.
@tconte-pass je me demande si l'ordre du or_ (d'abord la future offer puis ensuite l'offer released) a un impact sur la perf ?
There was a problem hiding this comment.
Je suppose que c'est postgres qui se charge de faire sa planification derrière ...
Mais ça me paraît bien comme ça, je pense pas que is_offer_released_with_bookable_stock soit plus rapide à calculer que la condition sur la futureOffer
|
Visit the preview URL for this PR (updated for commit 9a308b7): https://pc-pro-testing--pr15959-pc-33946-vm24f3wz.web.app (expires Thu, 23 Jan 2025 17:04:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
bpeyrou-pass
force-pushed
the
PC-33946
branch
from
5b4df29 to
9a308b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-33946
Vérifications