(PC-34341)[BO] fix: avoid crash at collective offer validation when ADAGE notification timeouts #16113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 3fb6567): https://pc-pro-testing--pr16113-pc-34341-bo-validate-9vwonapx.web.app (expires Sun, 02 Feb 2025 09:25:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
prouzet-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
vroullier-pass
approved these changes
Jan 30, 2025
api/src/pcapi/routes/backoffice/collective_offers/collective_offers_blueprint.py
Show resolved
Hide resolved
| assert endpoint.called | ||
|
|
||
| db.session.refresh(collective_offer) | ||
| assert collective_offer.isActive is True |
There was a problem hiding this comment.
Ici on voudrait plutôt False justement non i.e ne pas avoir validé l'offre ?
Et en fait.. ces tests ne fonctionnent pas vraiment, je suis déjà tombé dessus -> on a un mark_transaction_as_invalid dans un sous-bloc atomic, et dans les tests ça ne rollback pas correctement
There was a problem hiding this comment.
idem réponse au-dessus
jcicurel-pass
approved these changes
Jan 31, 2025
…DAGE notification timeouts
prouzet-pass
force-pushed
the
pc-34341-bo-validate-offers-adage-timeout
branch
from
92789ad to
3fb6567
Compare
prouzet-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira : https://passculture.atlassian.net/browse/PC-34341
Vérifications