Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent save profile without active modules #1164

Merged
merged 8 commits into from
Feb 11, 2025
Merged

Prevent save profile without active modules #1164

merged 8 commits into from
Feb 11, 2025

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Feb 11, 2025

A further improvement over #1163 with the same purpose. That is: if a profile won't connect, don't let the user create/save it in the first place.

@keeshux keeshux self-assigned this Feb 11, 2025
@keeshux keeshux added the enhancement New feature or request label Feb 11, 2025
@keeshux keeshux added this to the 3.1.0 / UX milestone Feb 11, 2025
@keeshux keeshux merged commit cc8a500 into master Feb 11, 2025
1 check passed
@keeshux keeshux deleted the feature/prevent-save-empty-modules branch February 11, 2025 16:45
@keeshux keeshux mentioned this pull request Feb 13, 2025
Merged
keeshux added a commit that referenced this pull request Feb 13, 2025
@keeshux
Fix UI tests for screenshots (#1168)
afee403 
Outdated after reworking the UI. Some fixes were also needed because:

- [WireGuardModule requires a
configuration](#1164)
- [OpenVPNModule is interactive when no credentials are
set](#1104)
- Mock profile had a wrong category ("" → "default")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@keeshux keeshux

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.1.0 / UX
Development

Successfully merging this pull request may close these issues.
1 participant
@keeshux