Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply system appearance via UIKit/AppKit #1200

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Apply system appearance via UIKit/AppKit #1200

merged 3 commits into from
Feb 18, 2025

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Feb 18, 2025 •
edited
Loading

SwiftUI implementation is fragile, system appearance with preferredColorScheme(nil) is buggy.

Instead, rely on:

  • iOS: UIKit → UIWindow.overrideUserInterfaceStyle
  • macOS: AppKit → NSApp.appearance

Amends #1077

Fixes #1199

@keeshux keeshux self-assigned this Feb 18, 2025
@keeshux keeshux added bug Something isn't working iOS Related to the iOS app macOS Related to the macOS app labels Feb 18, 2025
@keeshux keeshux merged commit 42a1861 into master Feb 18, 2025
1 check passed
@keeshux keeshux deleted the bugfix/system-appearance branch February 18, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@keeshux keeshux

Labels
bug Something isn't working iOS Related to the iOS app macOS Related to the macOS app
Projects
None yet
Milestone
3.2.0 / Features
Development

Successfully merging this pull request may close these issues.

"System" appearance is wrong
1 participant
@keeshux