Align the attribution algorithm with Cookie Monster #76
+30
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note this PR doesn't do the p-norm optimization as in the paper (if there is just a single epoch considered). I think we can hold off on that until budget deduction is fully spec'd. |
martinthomson
approved these changes
Feb 4, 2025
|
Feel free to merge if it LGTY. I don't have permission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deducts budget from all epochs with matching impressions, as per the cookie monster paper.
It also decouples a "common" attribution algorithm from the last-touch one, as all attribution algorithms need to first invoke the common matching logic and do budget deduction in the same way.
Fixes #75