triggerScrollToDateDelegate in calendar.scrollToDate now triggers willScrollToDateSegmentWith delegate function #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bystritskiy
reviewed
Dec 1, 2022
| // Ensure date is within valid boundary | ||
|
|
||
| // Ensure date is within valid boundary |
bystritskiy
reviewed
Dec 1, 2022
| @@ -384,7 +384,7 @@ | |||
| CLANG_ENABLE_MODULES = YES; | |||
| CODE_SIGN_STYLE = Automatic; | |||
| DEFINES_MODULE = YES; | |||
| DEVELOPMENT_TEAM = GBBYECNDQ9; | |||
bystritskiy
reviewed
Dec 1, 2022
| @@ -356,7 +356,7 @@ | |||
| CLANG_ENABLE_MODULES = YES; | |||
| CODE_SIGN_STYLE = Automatic; | |||
| DEFINES_MODULE = YES; | |||
| DEVELOPMENT_TEAM = GBBYECNDQ9; | |||
bystritskiy
reviewed
Dec 1, 2022
| @@ -551,7 +551,12 @@ extension JTACMonthView { | |||
| assert(false, "Could not determine CGPoint. This is an error. contact developer on github. In production, there will not be a crash, but scrolling will not occur") | |||
| return | |||
| } | |||
|
|
|||
|
|
|||
| if self.triggerScrollToDateDelegate == true { | |||
bystritskiy
reviewed
Dec 1, 2022
| @@ -178,4 +181,5 @@ public extension JTACMonthViewDelegate { | |||
| func calendarSizeForMonths(_ calendar: JTACMonthView?) -> MonthSize? { return nil } | |||
| func sizeOfDecorationView(indexPath: IndexPath) -> CGRect { return .zero } | |||
| func scrollDidEndDecelerating(for calendar: JTACMonthView) {} | |||
| func scrollDidEndScrollingAnimation(for calendar: JTACMonthView) {} | |||
bystritskiy
reviewed
Dec 1, 2022
| } | ||
| } | ||
|
|
||
| /// Tells the delegate that a scroll occured |
|
You need to fix merge conflicts :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for #1262. I am not an experienced developer, so if there are any mistakes or if you need any changes, let me know. It seems to solve my problem correctly for now.