-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support LPIPS when using LAB colorspace. #18
base: main
Are you sure you want to change the base?
Conversation
Can you call the function |
Also can you check if it affects the |
I didn't want to call it |
Maybe |
Sure, good point. But this was branched from |
I addressed a couple of @borisdayma's comments, but it turns out we can't use I checked the color conversion functions in We can port TensorFlow's implementation to JAX, but maybe we have more important things to do first. What do you think @borisdayma, @patil-suraj ? |
Addresses #12.
I also double-checked that the input for LPIPS are images in the range
[-1, 1]
, everything looks correct in that regard.