skip previous trained batches #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -560,6 +560,11 @@ def run( | |||
| output = None | |||
| stop_trace_step = None | |||
|
|
|||
| # skip previous batches | |||
| for i in range(self.step): | |||
| self.vlog(3, f"skipping batch for step {i}") | |||
There was a problem hiding this comment.
Do we need to add any unit tests for this case ?
There was a problem hiding this comment.
No unit tests planed for now since these are not merging to upstream.
aws-zhenguo
force-pushed
the
replay_trn
branch
from
46cb7e8 to
18212fd
Compare
|
LGTM but needs a test we can run on both GPU and TRN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.