feat: add EmptyStateErrorMessage and update a11y test dependency #64
Conversation
There was a problem hiding this comment.
I am now looking at component groups and wondering if this component is necessary to introduce, given that there already is ErrorState / MissingPage /... and these other EmptyState use cases.
Also I am not sure whether the <Stack> should be used, it creates this giant space between the title and body
| children, | ||
| }: EmptyStateErrorMessageProps) => ( | ||
| <EmptyState headingLevel="h2" icon={PathMissingIcon} titleText={title}> | ||
| <EmptyStateFooter> |
There was a problem hiding this comment.
The EmptyStateFooter probably shouldn't be here. I think it is a result of an old codemod I wrote one and a half year ago that did some stuff it shouldn't
| bodyText, | ||
| children, | ||
| }: EmptyStateErrorMessageProps) => ( | ||
| <EmptyState headingLevel="h2" icon={PathMissingIcon} titleText={title}> |
There was a problem hiding this comment.
Could the icon / headingLevel maybe be configurable with a prop? I see it isn't currently in the odh-dashboard, but for future use cases
That gives me an idea - let me take a second stab at this |
|
Once this component-groups issue gets resolved, we can use this component rather than reexport that component here (to make sure the API matches the old implementation in RHOAI |
nicolethoen
force-pushed
the
EmptyStateErrorMessage
branch
from
4f2efcd to
ce95fac
Compare
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #27