feat: Add PasswordInput and PasswordHiddenText components #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamviktora
reviewed
Nov 27, 2024
|
|
||
| import { PasswordInput, PasswordHiddenText } from "@patternfly/ai-infra-ui-components"; | ||
|
|
||
| Note: this component documents the API and enhances the [existing PasswordInput](https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/components/PasswordInput.tsx) component and [existing PasswordHiddenText](https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/components/PasswordHiddenText.tsx) component from odh-dashboard. It can be imported from [@patternfly/ai-infra-ui-components](https://www.npmjs.com/package/@patternfly/AI-infra-ui-components). Alternatively, it can be used within the odh-dashboard via the import: `~/components/PasswordInput`. |
There was a problem hiding this comment.
Maybe rewrite this to these components document ... and add the PasswordHiddenText import '~/components/PasswordHiddenText' too.
|
|
||
| return ( | ||
| <Flex | ||
| spaceItems={{ default: 'spaceItemsNone' }} |
There was a problem hiding this comment.
Can this be spaceItemsXs? I think with a little space between the password and the button (especially when it is hovered or clicked) it would look better
|
LGTM |
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #45
Closes: #46
Quick link to the new docs: https://ai-infra-ui-components-pr-75.surge.sh/ai-infra-ui-components/passwordinput