Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF6 documentation: mention that breakpoint token values have changed from px to rem and suggest a solution #4314

Closed
wise-king-sullyman opened this issue Oct 10, 2024 · 1 comment

Comments

@wise-king-sullyman
Copy link
Collaborator

Is this a new page or a change to an existing one?
Existing one

Describe the enhancement
We should advise consumers that any logic they have using the pixel values of our previous breakpoint tokens will need to be updated to account for the fact that they're now in rems.

As an example one consumer function I've seen so far stripped the px from the token value then parsed it as an integer, now an additional step of multiplying that int by 16 (the standard rem to pixel conversion) will need to be added.

@edonehoo
Copy link
Collaborator

Closed by #4332 🎉

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: No status
Development

No branches or pull requests

3 participants