docs(upgrade): Adds more detail to upgrade guide. #4332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wise-king-sullyman can you let me know if I interpreted the test failures correctly? |
packages/documentation-site/patternfly-docs/content/get-started/upgrade.md
Outdated
Show resolved
Hide resolved
Comment on lines
95
to
96
| 1. **Select (when using Jest):** Cannot find `role` | ||
| - You may get an "unable to find role" error if the Popper menu is set to `aria-disabled` after a selection is made, because the RTL query can't find the menu options. This error only seems to occur with Jest, rather than within the browser. To resolve this, either: |
There was a problem hiding this comment.
Suggested change
| 1. **Select (when using Jest):** Cannot find `role` | |
| - You may get an "unable to find role" error if the Popper menu is set to `aria-disabled` after a selection is made, because the RTL query can't find the menu options. This error only seems to occur with Jest, rather than within the browser. To resolve this, either: | |
| 1. **Select (when using React Testing Library):** Cannot find `role` | |
| - You may get an "unable to find role" error if the Popper menu is set to `aria-disabled` after a selection is made, because the RTL query can't find the menu options. This error only seems to occur in unit tests, rather than within the browser. To resolve this, either: |
It's more of an RTL thing than Jest, at least I think.
There was a problem hiding this comment.
I thought we were talking about right-to-left ahhaha
Amazing, ty!
There was a problem hiding this comment.
That is very much not the first time that RTL vs RTL confusion has happened haha
This was referenced Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes both #4277 and #4314