Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tooltips): Creates separate tooltips writing guide. #3999

Merged
merged 7 commits into from
May 15, 2024

Conversation

edonehoo
Copy link
Collaborator

@edonehoo edonehoo commented May 3, 2024

Closes #3992

Also CC: @abigaeljamie & @nicolethoen since you were both on this old/related thread

@edonehoo edonehoo marked this pull request as draft May 3, 2024 21:07
@edonehoo edonehoo self-assigned this May 3, 2024
@patternfly-build
Copy link
Contributor

patternfly-build commented May 3, 2024

@edonehoo edonehoo marked this pull request as ready for review May 9, 2024 20:58
Copy link
Collaborator

@abigaeljamie abigaeljamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Erin!

Copy link
Contributor

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome sauce!

@jessiehuff jessiehuff merged commit 6bf6db1 into patternfly:main May 15, 2024
4 checks passed
nicolethoen pushed a commit to nicolethoen/patternfly-org that referenced this pull request May 31, 2024
…3999)

* docs(tooltips): Creates separate tooltips writing guide.

* Edits content.

* Removes unused image.

* Content edits to prep for reviews.

* Adds some aria attributes.

* Cross link from icons guide.
nicolethoen added a commit that referenced this pull request Jun 3, 2024
* fix: bump to latest release candidates ahead of 5.2 release (#3862)

* fix: bump to latest release candidates ahead of 5.2 release

* bump to latest component groups prerelease

* bump react to pull in bug fix

* feat: release 5.3 (#3878)

* feat: 5.3 release

* update release highlights

* fix: Bump topology to 5.2.1 (#3881)

* fix: toplogy to 5.2.1

* add yarn.lock

* update release highlights

* Update broken link on develop.md

* chore(release): Updated component groups to 5.1.0 release (#3917)

* chore(release): releasing packages [ci skip]

 - @patternfly/[email protected]
 - @patternfly/[email protected]

chore(component-groups): Updated component groups to 5.1.0 release

chore(component-groups): Updated component groups to 5.1.0 release

* Updated version.json

* feat(Templates): add to org site (#3947)

* feat(Templates): add to org site

* update versions, fix Th

* hide prev version, update screenshots

* fix(docs): proper commit (#3968)

* feat(docs): update screenshots (#3969)

* Update link for deprecated alert (#3956)

* feat(docs): fix for missing props tables (#3981)

* chore(a11y): updated a11y scorecard (#3980)

* chore(a11y): updated a11y scorecard

* PR feedback - adjusted 'initial report' section with current data

* fix(misc): fix broken about links (#3987)

* add comparison table to table guidelines (#4006)

* add comparison table to table guidelines

* Update table.md

* Update table.md

* docs(tooltips): Creates separate tooltips writing guide. (#3999)

* docs(tooltips): Creates separate tooltips writing guide.

* Edits content.

* Removes unused image.

* Content edits to prep for reviews.

* Adds some aria attributes.

* Cross link from icons guide.

* fix: Incorrectly formatted link (#4024)

There was a link that was incorrectly formatted and let to a 404 page

* docs: Updates PatternFly mailing list link. (#4030)

* fix: update to official alpha omegas

* bump docs-framework version

---------

Co-authored-by: Donald Labaj <[email protected]>
Co-authored-by: kmcfaul <[email protected]>
Co-authored-by: Jessie <[email protected]>
Co-authored-by: Evan <[email protected]>
Co-authored-by: Margot <[email protected]>
Co-authored-by: Erin Donehoo <[email protected]>
Co-authored-by: Freya Gustavsson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve guidance around tooltip content for icons.
5 participants