add comparison table to table guidelines #4006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuzz0
previously approved these changes
May 7, 2024
edonehoo
previously approved these changes
May 8, 2024
| @@ -118,6 +118,32 @@ The actionable table provides checkboxes or radio buttons that enable users to s | |||
| #### When not to use | |||
| * Users can not take any actions on table items/rows. | |||
|
|
|||
| ### Comparison table | |||
There was a problem hiding this comment.
should we also add this as a list item on line 77?
There was a problem hiding this comment.
great catch!! Just updated
jessiehuff
approved these changes
May 9, 2024
nicolethoen
pushed a commit
to nicolethoen/patternfly-org
that referenced
this pull request
May 31, 2024
* add comparison table to table guidelines * Update table.md * Update table.md
nicolethoen
added a commit
that referenced
this pull request
Jun 3, 2024
* fix: bump to latest release candidates ahead of 5.2 release (#3862) * fix: bump to latest release candidates ahead of 5.2 release * bump to latest component groups prerelease * bump react to pull in bug fix * feat: release 5.3 (#3878) * feat: 5.3 release * update release highlights * fix: Bump topology to 5.2.1 (#3881) * fix: toplogy to 5.2.1 * add yarn.lock * update release highlights * Update broken link on develop.md * chore(release): Updated component groups to 5.1.0 release (#3917) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] chore(component-groups): Updated component groups to 5.1.0 release chore(component-groups): Updated component groups to 5.1.0 release * Updated version.json * feat(Templates): add to org site (#3947) * feat(Templates): add to org site * update versions, fix Th * hide prev version, update screenshots * fix(docs): proper commit (#3968) * feat(docs): update screenshots (#3969) * Update link for deprecated alert (#3956) * feat(docs): fix for missing props tables (#3981) * chore(a11y): updated a11y scorecard (#3980) * chore(a11y): updated a11y scorecard * PR feedback - adjusted 'initial report' section with current data * fix(misc): fix broken about links (#3987) * add comparison table to table guidelines (#4006) * add comparison table to table guidelines * Update table.md * Update table.md * docs(tooltips): Creates separate tooltips writing guide. (#3999) * docs(tooltips): Creates separate tooltips writing guide. * Edits content. * Removes unused image. * Content edits to prep for reviews. * Adds some aria attributes. * Cross link from icons guide. * fix: Incorrectly formatted link (#4024) There was a link that was incorrectly formatted and let to a 404 page * docs: Updates PatternFly mailing list link. (#4030) * fix: update to official alpha omegas * bump docs-framework version --------- Co-authored-by: Donald Labaj <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Jessie <[email protected]> Co-authored-by: Evan <[email protected]> Co-authored-by: Margot <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Freya Gustavsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added these guidelines https://docs.google.com/document/d/1Z6LyyqYTxKxCtYwRVywttHjL7v15AFt7FyAXJB8zNK0/edit to table guidelines
closes #3963