Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(components): Adds and expands on deprecation. #4226

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

edonehoo
Copy link
Collaborator

Closes #3983

@edonehoo edonehoo marked this pull request as draft August 27, 2024 20:30
@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 27, 2024

@edonehoo
Copy link
Collaborator Author

edonehoo commented Aug 28, 2024

Not sure how in depth we'd like to go on org? Made some small additions and edits to some of the existing messaging as a first pass. Also added a note for chip.

Eventually, this content could find a home in a different area based on #1301

@edonehoo edonehoo marked this pull request as ready for review August 28, 2024 13:27
@edonehoo edonehoo linked an issue Aug 28, 2024 that may be closed by this pull request
Copy link
Contributor

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

{newImplementationLink && (
<React.Fragment>
You can find the <Link to={newImplementationLink}>updated implementation here</Link>.
</React.Fragment>
)}
{' '}To learn more about the process, visit our <Link to="/get-started/about-patternfly#patternfly-release-cadence">about page</Link>.
{' '}To learn more about deprecated components, visit <Link to="/get-started/about-patternfly#deprecated-components">about PatternFly.</Link>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This anchor doesn't seem to be working - it links to the top of the page.

Copy link
Collaborator

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the anchor doesn't seem to be working - that should be a browser feature... looks good to me otherwise!

@nicolethoen nicolethoen merged commit 3935291 into patternfly:main Sep 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation around deprecation
5 participants