Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(section gallery): add exception for Tile #4359

Closed
wants to merge 3 commits into from
Closed

fix(section gallery): add exception for Tile #4359

wants to merge 3 commits into from

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Oct 31, 2024 •
edited
Loading

Part of #4343

Forces Tile to show as deprecated for the section gallery as well.

@kmcfaul kmcfaul changed the title Section gallery tile fix(section gallery): add exception for Tile Oct 31, 2024
@patternfly-build
Copy link
Contributor

patternfly-build commented Oct 31, 2024 •
edited
Loading

Preview: https://patternfly-org-pr-4359-site.surge.sh

@kmcfaul kmcfaul force-pushed the section-gallery-tile branch from f9037f5 to 9cfe9bf Compare October 31, 2024 14:31
evwilkin
evwilkin approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - much easier solution than nesting the id check further down!

@evwilkin
Copy link
Member

@kmcfaul this shouldn't be needed once #4378 merges

@kmcfaul
Copy link
Contributor Author

kmcfaul commented Nov 25, 2024

Will be closed by #4378

@kmcfaul kmcfaul closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evwilkin evwilkin evwilkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmcfaul @patternfly-build @evwilkin