Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump puppeteer and update screenshots #4394

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix: bump puppeteer and update screenshots #4394

merged 2 commits into from
Nov 26, 2024

Conversation

nicolethoen
Copy link
Collaborator

@nicolethoen nicolethoen commented Nov 25, 2024 •
edited
Loading

Closes #4395

@patternfly-build
Copy link
Contributor

patternfly-build commented Nov 25, 2024 •
edited
Loading

Preview: https://patternfly-org-pr-4394-site.surge.sh

@nicolethoen nicolethoen changed the title bump puppeteer and update screenshots fix: bump puppeteer and update screenshots Nov 25, 2024
@nicolethoen nicolethoen force-pushed the bump_puppeteer_version branch from dcae0cf to 6b5d8e5 Compare November 25, 2024 20:05
rebeccaalpert
rebeccaalpert approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this down. Screenshots seem to work locally, and the site seems to build correctly and I can see the sections. I didn't comb through the site though.

@nicolethoen nicolethoen requested a review from kmcfaul November 26, 2024 16:00
@kmcfaul kmcfaul merged commit 1ac1dac into patternfly:main Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebeccaalpert rebeccaalpert rebeccaalpert approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump puppeteer version (to match a11y tool)
4 participants
@nicolethoen @patternfly-build @rebeccaalpert @kmcfaul