Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleGroup - add iconPosition prop #10059

Closed
thatblindgeye opened this issue Feb 1, 2024 · 0 comments · Fixed by #10291
Closed

ToggleGroup - add iconPosition prop #10059

thatblindgeye opened this issue Feb 1, 2024 · 0 comments · Fixed by #10291
Assignees

Comments

@thatblindgeye
Copy link
Contributor

Is this a new component or an extension of an existing one?
Toggle group

Describe the feature
Followup to #10019
Similar to our Button component, we should add a prop to position the icon in a toggle group item so that it can come before or after the toggle item text (if any). The prop should only accept values "start" and "end" (Button/any other components should have deprecated "left" and "right" values)

Are there visuals for this feature? If applicable, please include examples for each state and for varying widths
Include screenshots or links to Marvel or other mockups.

Any other information?

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Feb 1, 2024
@tlabaj tlabaj added the sm label Feb 26, 2024
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues Feb 26, 2024
@tlabaj tlabaj added this to the Prioritized Backlog milestone Feb 26, 2024
@tlabaj tlabaj added the PF6 label Apr 9, 2024
@tlabaj tlabaj self-assigned this Apr 10, 2024
@kmcfaul kmcfaul moved this from Backlog to Not started in PatternFly Issues Apr 11, 2024
@tlabaj tlabaj linked a pull request Apr 19, 2024 that will close this issue
@kmcfaul kmcfaul closed this as completed Apr 24, 2024
@github-project-automation github-project-automation bot moved this from Not started to Done in PatternFly Issues Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants