Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Toggle group): Add support for icon position #10291

Merged
merged 5 commits into from
Apr 24, 2024
Merged

feat(Toggle group): Add support for icon position #10291

merged 5 commits into from
Apr 24, 2024

Conversation

tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Apr 19, 2024

What: Closes #10059

@tlabaj tlabaj requested a review from mcoker April 19, 2024 19:51
@tlabaj tlabaj linked an issue Apr 19, 2024 that may be closed by this pull request
ToggleGroup - add iconPosition prop #10059
Closed
@patternfly-build
Copy link
Contributor

patternfly-build commented Apr 19, 2024 •
edited
Loading

Preview: https://patternfly-react-pr-10291.surge.sh

A11y report: https://patternfly-react-pr-10291-a11y.surge.sh

mcoker
mcoker approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

adamviktora
adamviktora approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@adamviktora adamviktora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/react-core/src/components/ToggleGroup/ToggleGroupItem.tsx Outdated Show resolved Hide resolved
thatblindgeye
thatblindgeye requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few quick changes below.

Not a blocker, but an example description would be good to add in as well. Maybe something like, "When passing both the text and icon properties into a <ToggleGroupItem>, you can also pass in the iconPosition property to determine whether the icon is rendered at the start or end of the item." cc @edonehoo. We could also just open a followup to add descriptions for all ToggleGroup examples since there's not a lot of them, though.

packages/react-core/src/components/ToggleGroup/examples/ToggleGroupTextIcon.tsx Outdated Show resolved Hide resolved
packages/react-core/src/components/ToggleGroup/examples/ToggleGroupTextIcon.tsx Outdated Show resolved Hide resolved
packages/react-core/src/components/ToggleGroup/ToggleGroupItem.tsx Outdated Show resolved Hide resolved
@edonehoo
Copy link
Contributor

edonehoo commented Apr 22, 2024 •
edited
Loading

@thatblindgeye oo yeah let's do a followup and I can got ahead and fill out the whole page!

@thatblindgeye thatblindgeye mentioned this pull request Apr 22, 2024
Closed
@tlabaj tlabaj requested a review from thatblindgeye April 23, 2024 15:41
@thatblindgeye thatblindgeye merged commit 4166486 into patternfly:v6 Apr 24, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

This was referenced Apr 26, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamviktora adamviktora adamviktora approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@mcoker mcoker mcoker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ToggleGroup - add iconPosition prop
6 participants
@tlabaj @patternfly-build @edonehoo @mcoker @thatblindgeye @adamviktora