Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptionlist complex content demo #10237

Open
wants to merge 1 commit into
base: v5
Choose a base branch
from

Conversation

ajaypratap003
Copy link
Member

What: Closes #10228
Descriptionlist complex content demo

Additional issues:

@tlabaj tlabaj requested review from andrew-ronaldson, a team and mattnolting and removed request for a team April 17, 2024 13:42
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajaypratap003 this demo does not match any core demos and It is not needed.

@tlabaj tlabaj requested review from a team, tlabaj, kmcfaul, mattnolting and mmenestr and removed request for a team April 18, 2024 18:55
@ajaypratap003
Copy link
Member Author

closing this PR as this demo does not match any core demos and It is not needed.

@tlabaj tlabaj reopened this Apr 23, 2024
@patternfly-build
Copy link
Contributor

patternfly-build commented Apr 23, 2024

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment about imports below, but also some smaller updates needed to be closer to the core complex example

section: components
---

import BarsIcon from '@patternfly/react-icons/dist/esm/icons/bars-icon';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The imports here just need to be cleaned up to remove things that aren't actually being used in this demo.

@kmcfaul
Copy link
Contributor

kmcfaul commented May 8, 2024

@tlabaj This PR was closed and reopened, do we still want to add this demo?

@andrew-ronaldson
Copy link
Collaborator

If we were to keep this demo I'd want to click it back to design. The layout is a bit off in my mind.

@tlabaj
Copy link
Contributor

tlabaj commented May 10, 2024

@andrew-ronaldson @kmcfaul core has a complex content example for Description list. Adding this demo was to achieve core parity.

Copy link

This PR has been automatically marked as stale because it has not had recent activity.

@tlabaj
Copy link
Contributor

tlabaj commented Nov 13, 2024

@andrew-ronaldson should the core review be removed and we close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description list with complex content demo
6 participants