fix(DragDropSort): fix positioning of DragOverlay #10283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamviktora
requested review from
kmcfaul,
a team and
tlabaj
and removed request for
a team
|
Preview: https://patternfly-react-pr-10283.surge.sh A11y report: https://patternfly-react-pr-10283-a11y.surge.sh |
adamviktora
force-pushed
the
drag-drop-sort-bug
branch
from
a1c1e78 to
c2df45f
Compare
thatblindgeye
approved these changes
Apr 23, 2024
| @@ -159,7 +163,7 @@ export const DragDropSort: React.FunctionComponent<DragDropSortProps> = ({ | |||
| ); | |||
| } | |||
| })} | |||
| <DragOverlay>{activeId && getDragOverlay()}</DragOverlay> | |||
| {canUseDOM ? ReactDOM.createPortal(dragOverlay, document.getElementById('root')) : dragOverlay} | |||
There was a problem hiding this comment.
I feel like it might be worth adding a prop to be able to customize the element passed to createPortal, though also may be something to wait and see if anyone mentions any issue with it. Not a blocker for me to keep this as-is, so unless anyone else would want to see that update ☑️
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10090
Change was done based on this comment from the author of the
dnd-kitpackage.I assume that a div with
id="root"will always be present in a React app, which I don't know if it is 100% true.We should also do this change for V6 once DragDrop is removed from the
nextfolder.