fix(ClipboardCopy): Add string[] type to children #11177
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11177.surge.sh A11y report: https://patternfly-react-pr-11177-a11y.surge.sh |
Venefilyn
force-pushed
the
fix/string-array-clipboard-copy
branch
from
ce0fdf3 to
f1671dd
Compare
|
Actually it doesn't handle it correctly for some reason. @tlabaj do you happen to know what's happening?
|
The ClipboardCopy component already handles string[] but didn't have it written in the props as valid.
Venefilyn
force-pushed
the
fix/string-array-clipboard-copy
branch
from
f1671dd to
1325248
Compare
|
Ah nvm found the issue, was inside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ClipboardCopy component already handles string[] but didn't have it written in the props as valid.
What: Closes #11186
Additional issues: