New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE - SVG theme support #11224

Open

mattnolting wants to merge 1 commit into patternfly:main from mattnolting:svg-test

+187 −1

Contributor

mattnolting commented Nov 18, 2024 •

edited

Loading

What: Addresses patternfly/patternfly#7211

TLDR

Inline SVGs

Offer the most customizability and control. They can:

Be styled to specific theme / color values
Controlled granularly w/CSS
Built into react components

Linked SVGs can be controlled to a less degree. They can

Invert black/white colors
Not use styled gradients. They must be inline and should not be inverted on dark/light theme switching.

Potential updates topf-v6-c-brand
...


          test(svg-theme-support): svg theming demo

6c7089e

Contributor

patternfly-build commented Nov 18, 2024 •

edited

Loading

Preview: https://patternfly-react-pr-11224.surge.sh

A11y report: https://patternfly-react-pr-11224-a11y.surge.sh

tlabaj added the Do Not Merge label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels