Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(misc): update to new logo #11290

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Nov 25, 2024

What: Closes #9443

I initially tried to use the new horizontal logo with LoginPage, but it was very large and currently LoginPage has no method to customize the internal Brand component, so I went with the icon logo instead. LMK if we want to still go with the horizontal logo + add a Brand spread props to LoginPage.

@patternfly-build
Copy link
Contributor

patternfly-build commented Nov 25, 2024

@tlabaj tlabaj requested review from a team, wise-king-sullyman and tlabaj and removed request for a team December 2, 2024 15:23
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick nit below. I'd agree with adding a prop to spread to Brand in LoginPage, but not a blocker for this PR to me.

@wise-king-sullyman wise-king-sullyman merged commit ac75242 into patternfly:main Dec 13, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all instance of old PF logo in examples and demos to new logo
4 participants