fix(DualListSelector): Resolve tsc type issues #11346
Open
+20
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrances17
requested review from
wise-king-sullyman and
thatblindgeye
and removed request for
a team
|
Preview: https://patternfly-react-pr-11346.surge.sh A11y report: https://patternfly-react-pr-11346-a11y.surge.sh |
|
Can you please open PR against v6 branch as well is applicable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10695
This should resolve all
tscerror output cause by PF type declarations in PF5.I pulled down and worked off react-core 5.3.3 to replicate the same environment as the reporter of the issue, but could not reproduce the exact same set of tsc errors that they were encountering. However, there were 14 or so errors flagged by tsc (running in strict mode), all of which were located in
DualListSelector, so I cleaned these up. This should result in clean runs of the tsc compiler for PF5.