Charts: Added support for patterns #7390
Conversation
|
Preview: https://patternfly-react-pr-7390.surge.sh A11y report: https://patternfly-react-pr-7390-a11y.surge.sh |
dlabrecq
force-pushed
the
1136-patterns
branch
2 times, most recently
from
413a2c8 to
13cee67
Compare
dlabrecq
changed the title
packages/react-charts/src/components/Patterns/examples/patterms.md
Outdated
Show resolved
Hide resolved
packages/react-charts/src/components/Patterns/examples/patterms.md
Outdated
Show resolved
Hide resolved
|
@dlabrecq I'm taking another look at this and just had a couple of questions. Can you explain again how the patterns are generated/assigned? Are these just mapped by default based on the color theme chosen? Is it possible for the consumer using this to explicitly select the pattern that will be applied to a specific color, and if yes, how would they do that? |
|
@mcarrano Patterns are dynamically generated (unique for each chart) in order to apply colors from the selected color theme or custom color scale. Those generated patterns are applied in a specific order (via a URL), similar to the color theme ordering defined by PatternFly. If you were to use the multi-color theme; for example, colorized patterns would be displayed in that exact order. However, devs can create their own custom patterns as well. |
|
Added beta flags, requested by @mcarrano |
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Added support for patterns. For examples, please see https://patternfly-react-pr-7390.surge.sh/charts/patterns.
Reviewed with @mceledonia, @heyethankim, & @mcarrano.
Design issue: patternfly/patternfly-org#4369
Closes: #7537