feat: CSS vars updater package #801
Conversation
adamviktora
force-pushed
the
css-vars-updater
branch
from
2ffb4eb to
ac04c82
Compare
| "packages/class-name-updater" | ||
| "packages/class-name-updater", | ||
| "packages/css-vars-updater", | ||
| "packages/shared-helpers" |
There was a problem hiding this comment.
Do we want lerna managing and releasing the shared-helpers package? Or can it just be a private package that doesn't get published?
There was a problem hiding this comment.
It was meant to be a private package. It was necessary to add it to this packages list, so lerna can link the packages when building. I updated the shared-helpers package to be "private": true.
But if you see a reason to publish it, we can
There was a problem hiding this comment.
Ah nope, sounds good to me!
There was a problem hiding this comment.
Oh actually..... if it's a full dep in the other packages rather than a devDep will it actually work without the package being published? 🤔
There was a problem hiding this comment.
That's a good point, I don't know. LLM thinks it won't work, which makes sense given that shared-helpers won't be published anywhere. I at first thought that lerna can somehow bundle it into the other packages.
There was a problem hiding this comment.
It seems like there are ways we could bundle it in, or maybe make it into a devDep, though just publishing it would probably be the fastest/easiest route.
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "name": "shared-helpers", | |||
There was a problem hiding this comment.
If it is going to be a public package that we ship I think we should place it under the @patternfly npm org, and probably give it a more descriptive name like shared-codemod-helpers.
There was a problem hiding this comment.
So this is valid given your comment above
|
I did run into some issues trying to test this. Following your instructions I ran into an error that I guessed was related to needing to run a build, but then I also ran into an error trying to do that:
|
Closes: #795
class-name-updaterandcss-vars-updaterto ashared-helperslocal packageRelated to the actual css-vars-updater:
npx tsx [path to cli.ts] [path to the test.css file]