-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Selectable example #21
Upgrade Selectable example #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to resolve merge conflicts and add one missing type, other than that looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jenny-s51 Looks like your test is failing. |
@dlabaj thank you for taking a look - the fix for this is in this commit in the Filterable PR. If we merge #25 in first, the build should pass when we merge this one in |
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.0.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Removes references to deprecated v4 table.
Converted Selectable example to TSX/function components and refactored to use new PF5 Table
Towards #14 and #17