[DIST-20437] Version change for muffin_man #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishek-potbhare
requested review from
natesalisbury,
gavinritchie and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the query parameter name from PostedBefore to postedBefore for the Finances API endpoints. Key changes include:
- Updating the stub method in spec/support/finances/stub_finances.rb to conditionally append the postedBefore parameter.
- Updating tests in spec/muffin_man/finances/v20240619_spec.rb to pass the additional posted_before argument.
- Bumping the version and updating documentation in README.md and CHANGELOG.md.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| spec/support/finances/stub_finances.rb | Modified stub definition to include posted_before in the URL when provided. |
| spec/muffin_man/finances/v20240619_spec.rb | Updated test cases to supply posted_before to match the modified stub. |
| lib/muffin_man/version.rb | Bumped version to 2.4.14 reflecting the new changes. |
| README.md | Documented the addition of Finances API v2024-06-19 support. |
| CHANGELOG.md | Logged changes for version 2.4.14, including the query parameter fix. |
abhishek-potbhare
changed the title
mukteshd
reviewed
Apr 24, 2025
| def stub_list_financial_transactions(posted_after:) | ||
| stub_request(:get, "https://#{hostname}/finances/2024-06-19/transactions?postedAfter=#{posted_after}") | ||
| def stub_list_financial_transactions(posted_after:, posted_before: nil) | ||
| # stub_request(:get, "https://#{hostname}/finances/2024-06-19/transactions?postedAfter=#{posted_after}") |
abhishek-potbhare
changed the title
abhishek-potbhare
force-pushed
the
DIST-20437_Amzn-Financial-Transactions-Correct-Query-Parameters-for-amazon-sp-api
branch
from
f819533 to
490465c
Compare
abhishek-potbhare
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version change for muffin_man
updating documentation in README.md and CHANGELOG.md
Ticket:
https://app.clickup.com/t/2323726/DIST-20437
Changes also done through the below pr:
#98