fix ConcurrentModificationException from CallLog #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughsimpson
changed the title
hughsimpson
commented
Nov 29, 2024
3 tasks
|
On reflection it would be better to test both test frameworks concurrently, but right now I'm not intending to do that. I found it very difficult to get this error at all consistently but I recognised it from some seemingly-one-off flaky tests... Anyway, I'm happy with it as it stands. |
|
@barkhorn let's merge this |
|
Not sure when I publish this (need some time to understand how it works), probably on the weekend |
|
@barkhorn If you get to this before me, publish it as 6.1, please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes
Fixes
ConcurrentModificationException(c.f. comment on #527)The actual fix is the same as the one proposed in #462, but this also adds a test that fails on scala 2.13 & 3 without the fix.
The test is a little weird, but I couldn't write one that replicated the bug that wasn't a bit kooky....