Introduce ACTIVITY packet parsing to dev parser #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PAutilities doesn't build fine. Just cleared the cache, and rJava breaks that one too. See https://travis-ci.community/t/cannot-connect-to-java-from-r/9754. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows ACTIVITY packets to be parsed when
parser = "dev"(see #24). It hasn't been extensively tested, but it checked out on 400k rows of the file shared by @muschellij2 in #19.Build is failing on Travis due to rJava configuration issues. That may be related to paulhibbing/PAutilities#2, but that problem has been solved (paulhibbing/PAutilities#3, h/t @muschellij2) and PAutilities builds fine. Travis may need to be set to not install packages in
suggests, but in that case I would expect the same problem for PAutilities. Either way, that's a separate issue and this should work for ACTIVITY packets.