-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection state - master role #8
base: devel
Are you sure you want to change the base?
Conversation
Hi Tom, this is amazing! Tomorrow I will definitely look into this PR and then I'll be able to make proper comments. The PS: I've setup integration with Travis CI to build every PR and it seems this is failing. |
Concerning the build error : it looks that the examples break because of the new |
I started to review, but I had to stop at f16e3f3. On monday I'll finish this. |
Hello Paulo, Thanks for the review and sorry for the delay, I am quite busy these days... I will try to update the PR this week ! |
Ok! |
(version exchange only at the moment)
47a3ced
to
24a46e6
Compare
Hello ! I could finally find some time to take your remarks into account, sorry again for the delay... Unfortunately I couldn't test the code as I don't have the hardware with me at the moment but the previous version was working and I did only minor changes. It seems that the build fails because of a connection timeout somewhere, is there some way to launch it again ? Cheers, Tom |
I had to shut down the build server. Now it is working again and the error message is correct. |
24a46e6
to
cdb913b
Compare
Hello !
Here is my implementation of the connected state in Master role.
The provided example works for me in communication with a custom nRF51822 device (using Nordic S110). This device implements the Battery Service and a custom service that controls a LED via PWM, which allows to test data TX & RX.
I saw that you pushed quite a lot of commits since I wrote this, so I think I will have to work again on the events and callback part... Using the brand new
ll_plat
API ?