Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection state - master role #8

Open
wants to merge 13 commits into
base: devel
Choose a base branch
from

Conversation

tommag
Copy link
Contributor

@tommag tommag commented Sep 10, 2014

Hello !

Here is my implementation of the connected state in Master role.
The provided example works for me in communication with a custom nRF51822 device (using Nordic S110). This device implements the Battery Service and a custom service that controls a LED via PWM, which allows to test data TX & RX.

I saw that you pushed quite a lot of commits since I wrote this, so I think I will have to work again on the events and callback part... Using the brand new ll_plat API ?

@pauloborges
Copy link
Owner

Hi Tom, this is amazing!

Tomorrow I will definitely look into this PR and then I'll be able to make proper comments.

The ll_plat_* functions are an attempt to not break the stack logic while the upper layer (the "application") is processing some event/report. The idea is to execute application handlers in a lower priority than the stack code so these handlers will never block the RADIO and TIMER interruptions. Let's try to use these functions to see if they work properly.

PS: I've setup integration with Travis CI to build every PR and it seems this is failing.

@tommag
Copy link
Contributor Author

tommag commented Sep 12, 2014

Concerning the build error : it looks that the examples break because of the new blessed/events.h file that would have to be included along with ll.h. This part will probably have to be re-worked on anyway !

@pauloborges
Copy link
Owner

I started to review, but I had to stop at f16e3f3. On monday I'll finish this.

@tommag
Copy link
Contributor Author

tommag commented Sep 23, 2014

Hello Paulo,

Thanks for the review and sorry for the delay, I am quite busy these days... I will try to update the PR this week !

@pauloborges
Copy link
Owner

Ok!

@tommag
Copy link
Contributor Author

tommag commented Oct 5, 2014

Hello !

I could finally find some time to take your remarks into account, sorry again for the delay...

Unfortunately I couldn't test the code as I don't have the hardware with me at the moment but the previous version was working and I did only minor changes.

It seems that the build fails because of a connection timeout somewhere, is there some way to launch it again ?

Cheers,

Tom

@pauloborges
Copy link
Owner

I had to shut down the build server. Now it is working again and the error message is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants