Default mime type to application/octet-stream for unrecognized file t…

…ypes (nerfstudio-project#227) * Default mime type to application/octet-stream if cannot guess * format * infra mime type change * ruff * Try shortening --------- Co-authored-by: Brent Yi <[email protected]>
pauluhlenbruck · Jun 25, 2024 · aac5f78 · aac5f78
1 parent 202a251
commit aac5f78
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/viser/_viser.py b/src/viser/_viser.py
@@ -356,9 +356,8 @@ def send_file_download(
             chunk_size: Number of bytes to send at a time.
         """
         mime_type = mimetypes.guess_type(filename, strict=False)[0]
-        assert (
-            mime_type is not None
-        ), f"Could not guess MIME type from filename {filename}!"
+        if mime_type is None:
+            mime_type = "application/octet-stream"
 
         from ._gui_api import _make_unique_id
 

diff --git a/src/viser/infra/_infra.py b/src/viser/infra/_infra.py
@@ -392,8 +392,11 @@ async def viser_http_server(
 
             use_gzip = "gzip" in request_headers.get("Accept-Encoding", "")
 
+            mime_type = mimetypes.guess_type(relpath)[0]
+            if mime_type is None:
+                mime_type = "application/octet-stream"
             response_headers = {
-                "Content-Type": str(mimetypes.MimeTypes().guess_type(relpath)[0]),
+                "Content-Type": mime_type,
             }
 
             if source_path not in file_cache: