Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): add ability to compile using react compiler #6483

Merged
merged 5 commits into from
May 28, 2024

Conversation

AlessioGr
Copy link
Member

@AlessioGr AlessioGr commented May 23, 2024

Description

Adds build:reactcompiler command, which builds ui using babel + babel-plugin-react-compiler instead of swc

Learnings

When used in a project, we saw this error:
CleanShot 2024-05-23 at 19 46 27 Cannot read properties of undefined (reading 'H'). This is due to facebook/react#29057. Changed it to only compile client components explicitly marked with 'use client', that fixes it

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Chore (non-breaking change which does not add functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to the templates directory (does not affect core functionality)
  • Change to the examples directory (does not affect core functionality)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@AlessioGr AlessioGr requested a review from denolfe as a code owner May 23, 2024 23:46
@AlessioGr AlessioGr marked this pull request as draft May 23, 2024 23:46
@AlessioGr AlessioGr marked this pull request as ready for review May 24, 2024 01:57
@AlessioGr AlessioGr changed the title feat(ui): compile using react compiler chore(ui): add ability to compile using react compiler May 28, 2024
@AlessioGr AlessioGr merged commit 96181d9 into beta May 28, 2024
45 checks passed
@AlessioGr AlessioGr deleted the feat/babel-react-compiler branch May 28, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant