fix: handle publish locale with autosave enabled and close dropdown #8719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JessChowdhury
commented
Oct 15, 2024
JessChowdhury
commented
- Fix publish specific locale option when no published versions exist
- Close the publish locale dropdown on click
DanRibbens
requested changes
Oct 17, 2024
paulpopus
approved these changes
Nov 5, 2024
This was referenced Nov 5, 2024
DanRibbens
approved these changes
Nov 6, 2024
| @@ -139,7 +139,7 @@ export const DefaultPublishButton: React.FC<{ label?: string }> = ({ label: labe | |||
| if (isActive) { | |||
| return ( | |||
| <PopupList.ButtonGroup key={locale.code}> | |||
| <PopupList.Button onClick={() => publishSpecificLocale(locale.code)}> | |||
| <PopupList.Button onClick={() => [publishSpecificLocale(locale.code), close()]}> | |||
There was a problem hiding this comment.
The array is a bit strange, probably should be avoided. I'd expect it to be onClick={() => { publishSpecificLocale(locale.code); close(); }}> or similar.
|
🚀 This is included in version v3.0.0-beta.126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.