Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Occ config logging #394

Merged
merged 24 commits into from
Jun 24, 2024
Merged

Occ config logging #394

merged 24 commits into from
Jun 24, 2024

Conversation

satyakamala03
Copy link
Contributor

No description provided.

rasamala83
rasamala83 requested changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@rasamala83 rasamala83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests to validate this flow and periodic logging

lib/config.go Outdated Show resolved Hide resolved
lib/config.go Show resolved Hide resolved
lib/config.go Outdated Show resolved Hide resolved
lib/config.go Outdated Show resolved Hide resolved
lib/config.go Outdated Show resolved Hide resolved
rasamala83
rasamala83 reviewed Jun 10, 2024
View reviewed changes
mux/mux.go Outdated Show resolved Hide resolved
venkatsridhar95
venkatsridhar95 requested changes Jun 18, 2024
View reviewed changes
lib/main.go Outdated Show resolved Hide resolved
lib/main.go Outdated Show resolved Hide resolved
lib/main.go Outdated Show resolved Hide resolved
lib/main.go Outdated Show resolved Hide resolved
lib/config.go Outdated Show resolved Hide resolved
mux/mux.go Outdated Show resolved Hide resolved
lib/config.go Show resolved Hide resolved
lib/config.go Show resolved Hide resolved
tests/unittest/config_logging/main_test.go Outdated Show resolved Hide resolved
@rasamala83
Copy link
Collaborator

E16:21:27.38 OCC_CONFIG SATURATION-RECOVERY 0 saturation_recover_throttle_rate=30&saturation_recover_threshold=200
E16:21:27.38 LOGGER ALERT 0 Data=alert: [PROXY workerpool.go:122] 2 randomized start ms 0
E16:21:27.38 OCC_CONFIG WORKER-CONFIGURATIONS 0 max_stranded_time_interval=2000&high_load_max_stranded_time_interval=600111&enable_danglingworker_recovery=false&max_desire_healthy_worker_pct=90&lifespan_check_interval=10&lifo_scheduler_enabled=true&high_load_skip_initiate_recover_pct=80&max_db_connects_per_sec=10000&max_lifespan_per_child=0&max_requests_per_child=0
E16:21:27.38 OCC_CONFIG NO-CATEGORY 0 database_type=0&cfg_from_tns=true&log_level=5&high_load_pct=130&init_limit_pct=125&num_standby_dbs=1
E16:21:27.38 LOGGER ALERT 0 Data=alert: [PROXY workerpool.go:122] 0 randomized start ms 0
E16:21:27.38 OCC_CONFIG SHARDING 0 enable_whitelist_test=false&sharding_cfg_reload_interval=3600&num_shards=3&scuttle_col_name=scuttle_id&max_scuttle=1024&cfg_from_tns_override_num_shards=-1&shard_key_value_type_is_string=false&whitelist_children=0&use_shardmap=true&shard_key_name=id&hostname_prefix=map[]&sharding_cross_keys_err=false&sharding_algo=false&enable_sharding=true&sharding_postfix=
E16:21:27.38 OCC_CONFIG BIND-EVICTION 0 bind_eviction_threshold_pct=60&query_bind_blocker_min_sql_prefix=20&enable_connlimit_check=false&child.executable=mysqlworker&bind_eviction_decr_per_sec=10&bind_eviction_target_conn_pct=50&bind_eviction_max_throttle=20&bind_eviction_names=id,num,srcPrefixApp&skip_eviction_host_prefix=&eviction_host_prefix=
E16:21:27.38 OCC_CONFIG SOFT-EVICTION 0 soft_eviction_effective_time=10000&soft_eviction_probability=50
E16:21:27.38 OCC_CONFIG RAC 0 management_table_prefix=hera&rac_sql_interval=0&rac_restart_window=240
E16:21:27.38 OCC_CONFIG BACKLOG 0 backlog_pct=30&request_backlog_timeout=1000&short_backlog_timeout=30
E16:21:27.38 OCC_CONFIG BOUNCER 0 bouncer_enabled=true&bouncer_startup_delay=10&bouncer_poll_interval_ms=100

@venkatsridhar95 venkatsridhar95 merged commit 26a4881 into paypal:main Jun 24, 2024
6 of 7 checks passed
rasamala83 added a commit to rasamala83/hera that referenced this pull request Jul 18, 2024
@rasamala83 @satyakamala03
@isatyakamala @rajesh-1983
Otel integration changes latest 2 (paypal#85)
13fc522 
* Occ config logging (paypal#394)

* occ configurations logging

* cal event success

* adding cal data

* added TODOs

* Remove log_occ_confogs.go

* Remove testing files

* source of configs - files

* whitelist format change

* code clean up

* code review changes-1

* CR fixes

* CR fixes

* Delete tests/unittest/config_logging/main_test.go

* clean up

* Merge branch 'occ-config-logging' of /Users/simmidisetty/Documents/GitHub/OpenSourceHera/src/github.com/paypal/hera with conflicts.

* test for config logging

* removing test changes

* tests for all cases

* test

* making minor changes for logging feature specific data

* changes for incorporate review comments

---------

Co-authored-by: simmidisetty <[email protected]>
Co-authored-by: Rajesh S <[email protected]>

* making changes updating port for metric and traces

---------

Co-authored-by: satyakamala03 <[email protected]>
Co-authored-by: simmidisetty <[email protected]>
Co-authored-by: Rajesh S <[email protected]>
rasamala83 added a commit to rasamala83/hera that referenced this pull request Aug 2, 2024
@rasamala83 @satyakamala03
@isatyakamala @rajesh-1983
Occ config logging (paypal#394) (paypal#91)
629c290 
* occ configurations logging

* cal event success

* adding cal data

* added TODOs

* Remove log_occ_confogs.go

* Remove testing files

* source of configs - files

* whitelist format change

* code clean up

* code review changes-1

* CR fixes

* CR fixes

* Delete tests/unittest/config_logging/main_test.go

* clean up

* Merge branch 'occ-config-logging' of /Users/simmidisetty/Documents/GitHub/OpenSourceHera/src/github.com/paypal/hera with conflicts.

* test for config logging

* removing test changes

* tests for all cases

* test

* making minor changes for logging feature specific data

* changes for incorporate review comments

---------

Co-authored-by: satyakamala03 <[email protected]>
Co-authored-by: simmidisetty <[email protected]>
Co-authored-by: Rajesh S <[email protected]>
rasamala83 added a commit to rasamala83/hera that referenced this pull request Aug 2, 2024
@rasamala83 @satyakamala03
@isatyakamala @rajesh-1983
Otel changes for adding host dimension (paypal#93)
db14446 
* Occ config logging (paypal#394)

* occ configurations logging

* cal event success

* adding cal data

* added TODOs

* Remove log_occ_confogs.go

* Remove testing files

* source of configs - files

* whitelist format change

* code clean up

* code review changes-1

* CR fixes

* CR fixes

* Delete tests/unittest/config_logging/main_test.go

* clean up

* Merge branch 'occ-config-logging' of /Users/simmidisetty/Documents/GitHub/OpenSourceHera/src/github.com/paypal/hera with conflicts.

* test for config logging

* removing test changes

* tests for all cases

* test

* making minor changes for logging feature specific data

* changes for incorporate review comments

---------

Co-authored-by: simmidisetty <[email protected]>
Co-authored-by: Rajesh S <[email protected]>

* adding host dimension in data-point level

---------

Co-authored-by: satyakamala03 <[email protected]>
Co-authored-by: simmidisetty <[email protected]>
Co-authored-by: Rajesh S <[email protected]>
rasamala83 added a commit to rasamala83/hera that referenced this pull request Aug 2, 2024
@rasamala83 @satyakamala03
@isatyakamala @rajesh-1983
Otel dist metrics change (paypal#96)
16789da 
* Occ config logging (paypal#394)

* occ configurations logging

* cal event success

* adding cal data

* added TODOs

* Remove log_occ_confogs.go

* Remove testing files

* source of configs - files

* whitelist format change

* code clean up

* code review changes-1

* CR fixes

* CR fixes

* Delete tests/unittest/config_logging/main_test.go

* clean up

* Merge branch 'occ-config-logging' of /Users/simmidisetty/Documents/GitHub/OpenSourceHera/src/github.com/paypal/hera with conflicts.

* test for config logging

* removing test changes

* tests for all cases

* test

* making minor changes for logging feature specific data

* changes for incorporate review comments

---------

Co-authored-by: simmidisetty <[email protected]>
Co-authored-by: Rajesh S <[email protected]>

* changes for otel integration in hera

---------

Co-authored-by: satyakamala03 <[email protected]>
Co-authored-by: simmidisetty <[email protected]>
Co-authored-by: Rajesh S <[email protected]>
rasamala83 added a commit to rasamala83/hera that referenced this pull request Aug 2, 2024
@rasamala83 @satyakamala03
@isatyakamala @rajesh-1983
Otel incorporate review comments and uts (paypal#98)
be68655 
* Occ config logging (paypal#394)

* occ configurations logging

* cal event success

* adding cal data

* added TODOs

* Remove log_occ_confogs.go

* Remove testing files

* source of configs - files

* whitelist format change

* code clean up

* code review changes-1

* CR fixes

* CR fixes

* Delete tests/unittest/config_logging/main_test.go

* clean up

* Merge branch 'occ-config-logging' of /Users/simmidisetty/Documents/GitHub/OpenSourceHera/src/github.com/paypal/hera with conflicts.

* test for config logging

* removing test changes

* tests for all cases

* test

* making minor changes for logging feature specific data

* changes for incorporate review comments

---------

Co-authored-by: simmidisetty <[email protected]>
Co-authored-by: Rajesh S <[email protected]>

* changes for incorporate review comments

---------

Co-authored-by: satyakamala03 <[email protected]>
Co-authored-by: simmidisetty <[email protected]>
Co-authored-by: Rajesh S <[email protected]>
rasamala83 added a commit to rasamala83/hera that referenced this pull request Sep 19, 2024
@rasamala83 @satyakamala03
@isatyakamala @rajesh-1983
Otel dimension fixes (paypal#105)
057a0a3 
* Occ config logging (paypal#394)

* occ configurations logging

* cal event success

* adding cal data

* added TODOs

* Remove log_occ_confogs.go

* Remove testing files

* source of configs - files

* whitelist format change

* code clean up

* code review changes-1

* CR fixes

* CR fixes

* Delete tests/unittest/config_logging/main_test.go

* clean up

* Merge branch 'occ-config-logging' of /Users/simmidisetty/Documents/GitHub/OpenSourceHera/src/github.com/paypal/hera with conflicts.

* test for config logging

* removing test changes

* tests for all cases

* test

* making minor changes for logging feature specific data

* changes for incorporate review comments

---------

Co-authored-by: simmidisetty <[email protected]>
Co-authored-by: Rajesh S <[email protected]>

* adding new tests and dimension value change

---------

Co-authored-by: satyakamala03 <[email protected]>
Co-authored-by: simmidisetty <[email protected]>
Co-authored-by: Rajesh S <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasamala83 rasamala83 rasamala83 requested changes

@venkatsridhar95 venkatsridhar95 venkatsridhar95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@satyakamala03 @rasamala83 @venkatsridhar95 @isatyakamala @rajesh-1983