Fix panic during bind throttle #404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtiencode
reviewed
Nov 6, 2024
| @@ -138,11 +138,12 @@ func bindEvictNameOk(bindName string) (bool) { | |||
| bind name and values */ | |||
| func (mgr *adaptiveQueueManager) doBindEviction() (int) { | |||
There was a problem hiding this comment.
The outer lock on bindevict is being held for too long. It gets unlocked only after inner lock on workerpool is done processing dispatched workers.
There was a problem hiding this comment.
Though it is on copy. It is safe reduce scope of the lock
| } | ||
| } | ||
|
|
||
| func (bindEvict *BindEvict) updateThrottle(entry *BindThrottle) { |
There was a problem hiding this comment.
This function needs to be used with caution (hold the lock when updating the copy), the new struct has a different lock.
There was a problem hiding this comment.
Can we change decrease logic also to avoid slow recovery?
rasamala83
approved these changes
Nov 15, 2024
| @@ -138,11 +138,12 @@ func bindEvictNameOk(bindName string) (bool) { | |||
| bind name and values */ | |||
| func (mgr *adaptiveQueueManager) doBindEviction() (int) { | |||
There was a problem hiding this comment.
Though it is on copy. It is safe reduce scope of the lock
| } | ||
| } | ||
|
|
||
| func (bindEvict *BindEvict) updateThrottle(entry *BindThrottle) { |
There was a problem hiding this comment.
Can we change decrease logic also to avoid slow recovery?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.