Implement FetchAllHostsMetrics for SignalFx using new API #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangchen615
previously approved these changes
Mar 3, 2021
Signed-off-by: Abdul Qadeer <[email protected]>
Fix bug in result set size Average returned values for metrics per window size Signed-off-by: Abdul Qadeer <[email protected]>
ridv
approved these changes
Mar 3, 2021
| // Find the average across returned values per 1 minute resolution | ||
| var sum float64 | ||
| var count float64 | ||
| for _, value := range values { |
There was a problem hiding this comment.
For testing, we may want to break this arithmetic mean calculation into its own function but not a blocker for now.
There was a problem hiding this comment.
Sure will do it in future PR when I add tests #26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abdul Qadeer [email protected]
This resolves #24