Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update font-family + update font-weight for poweredBy #2482

Merged
merged 4 commits into from
Mar 26, 2025

Conversation

hnguyen510
Copy link
Contributor

Description

Updated font-family and font-weight based on design suggestion.

Why are we making these changes? Include references to any related Jira tasks or GitHub Issues

Reproduction Steps (if applicable)

Screenshots (if applicable)

Dependent Changes (if applicable)

Groups who should review (if applicable)

❤️ Thank you!

@hnguyen510 hnguyen510 marked this pull request as ready for review March 24, 2025 17:49
@hnguyen510 hnguyen510 requested a review from a team as a code owner March 24, 2025 17:49
font-size: 11px;
font-weight: normal;
font-weight: 400;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add font-weight: 400; to src/ui/buttons/styles/button.js as well for CLASS.TAGLINE

Copy link
Contributor

@nikrom17 nikrom17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fierce 💯

@hnguyen510 hnguyen510 merged commit 44b7f0b into main Mar 26, 2025
3 checks passed
@hnguyen510 hnguyen510 deleted the feature/update-fonts branch March 26, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants