-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a 'theme' command #1603
base: master
Are you sure you want to change the base?
Conversation
to be able to change the theme dynamically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks safe but needs cleaning up.
class ThemeCommand(Command): | ||
|
||
"""move in widget""" | ||
def __init__(self, theme_name=None, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not do anything so could be omitted? the docstring is also not correct is it?
I have not yet tested this but I agree that this feature would be nice to have. |
It doesn't work yet for some reason, the error message |
still a WIP so no need to review yet but at least it's working. Planning to autocomplete theme name.
It's hard to read + If you want to create a theme, you have to set all of those. |
hum I was looking at how to pass CI but I notice none of the current PRs pass CI: is that even doable ? |
to be able to change the theme dynamically see #1588
When running the command in development mode, I get:
Could not read toto and/or /home/teto/alot/alot/settings/../defaults/theme.spec
What is weird too is that starting alot in development mode takes 5 sec while the system one starts <1 sec . The system alot took longer the first time though so I wonder if alot generates some cache along the way ? Same happened with neomutt, took a long time starting the first time I ran it in a while then successive starts were much faster. I've got 136675 messages in DB and ran a notmuch compact.